Skip to content

navin/fal 4077/backport/follow up#36644

Closed
navinkarkera wants to merge 3 commits intoopenedx:masterfrom
open-craft:navin/fal-4077/backport/follow-up
Closed

navin/fal 4077/backport/follow up#36644
navinkarkera wants to merge 3 commits intoopenedx:masterfrom
open-craft:navin/fal-4077/backport/follow-up

Conversation

@navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented May 1, 2025

Cup0fCoffee and others added 3 commits April 30, 2025 17:24
@Cup0fCoffee @farhaanbukhsh
feat: update certificate icon
2fb4cba 
Old certificates icon contained edX trademark logo, which was not
suitable for the open source repos. Replaced with the icon that contains
Open edX logo.
@ihor-romaniuk @arbrandes
fix: unit xblock adaptivity and small visual enhancements
c0bea2b
@navinkarkera
refactor: update sync model helper function docs and minor cleanup (o…
e0df512 
…penedx#36599)

* refactor: update sync model helper function docs

Adds some comments to explain certain confusing sections

* refactor: sync library content method

* feat: use edited_on block field

* test: modified field in course block index

* fix: extract uncommon methods to child class from base
@openedx-webhooks
Copy link

openedx-webhooks commented May 1, 2025

Thanks for the pull request, @navinkarkera!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 1, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@navinkarkera @openedx-webhooks @Cup0fCoffee @ihor-romaniuk

Comments